Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Pin setuptools for python dev #44989

Merged
merged 5 commits into from
Dec 21, 2021
Merged

CI: Pin setuptools for python dev #44989

merged 5 commits into from
Dec 21, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 20, 2021 •
edited
Loading

@phofl phofl added CI Continuous Integration Dependencies Required and optional dependencies labels Dec 20, 2021
@MarcoGorelli
Copy link
Member

should this

pandas/ci/setup_env.sh

Line 109 in d228a78

python -m pip install --no-deps -U pip wheel setuptools

also be pinned?

@phofl
Copy link
Member Author

phofl commented Dec 20, 2021

Yep, thx

@phofl
Pin in azure
bc0d5ed 
Pin additional
@mroeschke
Copy link
Member

Could you leave a TODO comment nearby the change referencing pypa/setuptools#2941?

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

Done

@jreback
Copy link
Contributor

jreback commented Dec 21, 2021

merge when ready

@jbrockmendel
Copy link
Member

uhh the ArrayManager tests have been going for 4 hours and counting

@alimcmaster1
Copy link
Member

uhh the ArrayManager tests have been going for 4 hours and counting

hmm 3hrs on second attempt..

Should be allow >=60.0.3 given this release fixes the issue?

jonashaag
jonashaag reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@jonashaag jonashaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 60.0.3

.github/workflows/python-dev.yml Show resolved Hide resolved
.github/workflows/python-dev.yml Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
ci/setup_env.sh Show resolved Hide resolved
ci/setup_env.sh Show resolved Hide resolved
@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

I think we should be able to avoid pinning this, if the newest version works?

@MarcoGorelli
Copy link
Member

yes, agreed

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021 •
edited
Loading

Looks like it does not adress all problems, https://github.com/pandas-dev/pandas/runs/4594019360?check_suite_focus=true

Edit: Can reproduce locally

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

The experimental data manager issue seems unrelated. I can also see this at https://github.com/pandas-dev/pandas/runs/4594019873?check_suite_focus=true. This has the newest setuptools

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

experimental data manager failure is unrelated, see #44994

@jbrockmendel
Copy link
Member

other than ArrayManager is this ready?

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

Yes

@jreback
Copy link
Contributor

jreback commented Dec 21, 2021

Yes

ok and the AM tests broke on the json changes?

@jreback jreback added this to the 1.4 milestone Dec 21, 2021
@jreback
Copy link
Contributor

jreback commented Dec 21, 2021

actually can we just unpin this? e.g. if >=60.0.3 its working?

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

60.0.3 does not work unfortunately. There are still problems. Posted some more info on the issue.

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

Yes AM case was from the json change

@jreback jreback merged commit e86cad9 into pandas-dev:master Dec 21, 2021
@jreback
Copy link
Contributor

jreback commented Dec 21, 2021

cool thanks @phofl

ok if you don't mind disabling the failing tests in AM build for the json (and create an issue about it) to get the CI back to green :->

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

#44999

@phofl phofl deleted the pin_setuptools branch December 21, 2021 17:01
@phofl phofl mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonashaag jonashaag jonashaag left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@phofl @MarcoGorelli @mroeschke @jreback @jbrockmendel @alimcmaster1 @jonashaag